esiur/esiur-dart
2
0
Fork 0
mirror of https://github.com/esiur/esiur-dart.git synced 2025-05-06 12:02:57 +00:00
Code Issues Projects Releases Wiki Activity

unnecessary deattach

Browse Source
This commit is contained in:
Ahmed Zamil 2024-07-09 19:17:09 +03:00
parent 3087e0d1ad
commit 675b94e909
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
lib/src/Net/IIP/DistributedConnection.dart
View File

@ -1727,15 +1727,25 @@ class DistributedConnection extends NetworkConnection with IStore {
AsyncReply<dynamic>? sendDetachRequest(int instanceId) { AsyncReply<dynamic>? sendDetachRequest(int instanceId) {
try { try {
if (_attachedResources.containsKey(instanceId)) var sendDetach = false;
if (_attachedResources.containsKey(instanceId)){
_attachedResources.remove(instanceId); _attachedResources.remove(instanceId);
sendDetach = true;
}
if (_suspendedResources.containsKey(instanceId)) if (_suspendedResources.containsKey(instanceId)){
_suspendedResources.remove(instanceId); _suspendedResources.remove(instanceId);
sendDetach = true;
}
if (sendDetach)
return (_sendRequest(IIPPacketAction.DetachResource)
..addUint32(instanceId))
.done();
return null;
return (_sendRequest(IIPPacketAction.DetachResource)
..addUint32(instanceId))
.done();
} catch (ex) { } catch (ex) {
return null; return null;
} }
@ -1815,10 +1825,16 @@ class DistributedConnection extends NetworkConnection with IStore {
} }
} }
void iipEventResourceReassigned(int resourceId, int newResourceId) {} void iipEventResourceReassigned(int resourceId, int newResourceId) {
}
void iipEventResourceDestroyed(int resourceId) { void iipEventResourceDestroyed(int resourceId) {
var r = _attachedResources[resourceId]?.target; var r = _attachedResources[resourceId]?.target;
// remove from attached to avoid sending unnecessary deattach request when Destroy() is called
_attachedResources.remove(resourceId);
if (r != null) { if (r != null) {
r.destroy(); r.destroy();
return; return;
@ -1827,7 +1843,6 @@ class DistributedConnection extends NetworkConnection with IStore {
_neededResources.remove(resourceId); _neededResources.remove(resourceId);
} }
_attachedResources.remove(resourceId);
} }
// @TODO: Check for deadlocks // @TODO: Check for deadlocks